[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30122 [Core Tor/Stem]: Make stem's unit tests propagate the backtrace signals to child processes

#30122: Make stem's unit tests propagate the backtrace signals to child processes
-----------------------------------+--------------------------
 Reporter:  teor                   |          Owner:  teor
     Type:  enhancement            |         Status:  reopened
 Priority:  Medium                 |      Milestone:
Component:  Core Tor/Stem          |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  tor-ci-fail-sometimes  |  Actual Points:  0.4
Parent ID:  #29437                 |         Points:  0.5
 Reviewer:                         |        Sponsor:
-----------------------------------+--------------------------
Changes (by teor):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Thanks for the merge and improvements!

 I just noticed that there is still a race condition here, if the process
 is alive when the list is created, and for the is_alive() check, but exits
 before it is signalled:
 {{{
 -    # avoid race conditions
      if p.is_alive():
 }}}

 We should just ignore the exception instead:
 https://github.com/torproject/stem/pull/13

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30122#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs