[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #29280 [Core Tor/Tor]: Use Chutney in Tor's CI
#29280: Use Chutney in Tor's CI
-------------------------------------------------+-------------------------
Reporter: cohosh | Owner: (none)
Type: task | Status:
| needs_revision
Priority: High | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: CI, PTs 029-backport 034-backport | Actual Points: 1
035-backport 040-backport, network-team- |
roadmap-2019-Q1Q2 |
Parent ID: #29267 | Points: 1
Reviewer: teor | Sponsor:
| Sponsor19
-------------------------------------------------+-------------------------
Comment (by teor):
Oops, I forgot to review 0.3.4 and later:
I am not so sure about this part of the merge commit to 0.3.4:
{{{
++ - env: DISTCHECK="yes" RUST_OPTIONS="--enable-rust --enable-cargo-
online-mode" HARDENING_OPTIONS="" SKIP_MAKE_CHECK="yes"
}}}
I don't think we should skip make check on the only online rust build. We
could move online to the dirauth build, and skip make check on distcheck?
Also, in future, let's try to do semantic changes like this in a separate
commit?
https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/MergePolicy?action=diff&version=11
In 0.3.5, you dropped the SKIP_MAKE_CHECK you added in 0.3.4:
{{{
- ## But without hardening (see above)
- - env: DISTCHECK="yes" RUST_OPTIONS="--enable-rust --enable-cargo-
online-mode" HARDENING_OPTIONS="" SKIP_MAKE_CHECK="yes"
+ - env: DISTCHECK="yes" RUST_OPTIONS="--enable-rust --enable-cargo-
online-mode"
}}}
We should also re-run all these branches with the latest chutney.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29280#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs