[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30252 [Core Tor/sbws]: Add the tor OpenSSL and NSS versions to the sbws bandwidth file headers
#30252: Add the tor OpenSSL and NSS versions to the sbws bandwidth file headers
---------------------------+-----------------------------------
Reporter: teor | Owner: (none)
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: sbws: 1.2.x-final
Component: Core Tor/sbws | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: #30255 | Points:
Reviewer: | Sponsor:
---------------------------+-----------------------------------
Changes (by teor):
* status: new => needs_revision
Comment:
Replying to [comment:6 juga]:
> Reminder to myself: i've implemented the operating system, ssl_version
and tor_version in branch https://github.com/juga0/sbws/tree/ticket30196
Here's my review of ssl_version:
* we need Tor's OpenSSL version, not Python's OpenSSL version
* we need Tor's NSS version (if it is using NSS). Tor can use OpenSSL and
NSS at the same time.
* you added tor_version in two places, but ssl_version in one place.
Please refactor EXTRA_ARG_KEYVALUES and BANDWIDTH_HEADER_KEY_VALUES_INIT
so the headers are consistent.
* please submit a bandwidth-file-spec patch, so the reviewer knows what
your code should do
* does the "chg: v3bwfile: !refactor, obtain headers from state" commit
belong in a separate pull request? It's quite large.
* please submit each feature in a separate pull request
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30252#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs