[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23588 [Core Tor/Tor]: Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs()
#23588: Write fascist_firewall_choose_address_ls() and use it in
hs_get_extend_info_from_lspecs()
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: enhancement | Status:
| needs_review
Priority: Low | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.2.1-alpha
Severity: Normal | Resolution:
Keywords: prop224, tor-hs, single-onion, | Actual Points: 2
ipv6, 034-triage-20180328, |
034-removed-20180328, 040-unreached-20190109, |
041-proposed, v3-onion-service-feature- |
parity-can |
Parent ID: #23493 | Points: 1
Reviewer: | Sponsor:
| Sponsor27-must
-------------------------------------------------+-------------------------
Changes (by teor):
* priority: Medium => Low
* reviewer: teor =>
* actualpoints: 1.5 => 2
Comment:
I have already reviewed the first 3 commits from neel.
I rebased neel's code on master, and added 5 extra commits:
* Update 23588 changes file to say what the patch actually does
* test/hs: Re-enable the IPv6 intro point in the HS tests
* test/hs: Correctly convert an IPv6 intro point to an extend_info
* hs_config: Allow Tor to be configured as an IPv6-only v3 single onion
service
* practracker: Accept ~80 extra lines in src/core/or/policies.c
The code passes:
{{{
make check
make test-network-all
# The IPv6-only v3 onion service chutney network
~/chutney/tools/test-network.sh --flavour single-onion-v23-ipv6-md
}}}
Someone else should review and merge this code.
But it's not a high priority.
We can wait for Sponsor 27 if we'd like.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23588#comment:83>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs