Re: [tor-bugs] #29981 [Applications/Tor Browser]: Add option to build without using containers

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#29981: Add option to build without using containers
-------------------------------------------------+-------------------------
 Reporter:  boklm                                |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201904,       |  Actual Points:
  tbb-8.5                                        |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, TorBrowserTeam201904R, tbb-8.5 => tbb-rbm,
     TorBrowserTeam201904, tbb-8.5


Comment:

 Replying to [comment:25 boklm]:
 > So it seems yasm is not needed for the android-armv7 build, but still
 needed for the android-x86 one.
 >
 > In branch `bug_29981_v8` I added a new commit mentioning that in the
 README:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_29981_v8&id=1959d1c9dbe993b8fb4732b333892cb04f7ccfae

 The previous `apt-get install` comment does not talk about `android-armv7`
 specifically, thus starting now talking of `android-x86` seems a bit weird
 to me. I think *if* we go with just installing `yasm` everywhere to not
 create an extra container (I agree with that idea) then we should treat it
 as a first-class citizen here and just add it to the other packages.
 Otherwise we are starting to divert regarding installed packages between
 container/non-container builds (think of folks thinking "I only want to
 build `android-armv7` packages, thus no yasm for me`) which might fall
 onto our feet at some point.

 Maybe a note in the commit message would be enough to help us remembering
 in case we stumble over that again in the future? Otherwise I could think
 of "This can be done
 with the following command (note: yasm is only needed for android-x86
 builds):" to make our point clear while minimizing the risk for deviating
 from the packages installed in our container builds.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29981#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs