[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #33414 [Core Tor/Tor]: Split router.c, and disable it (mostly) when building without relay support.

#33414: Split router.c, and disable it (mostly) when building without relay
support.
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-design, network-team-roadmap-    |  Actual Points:  0.5
  2020Q1, 043-deferred                           |
Parent ID:  #31851                               |         Points:  0.5
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 >  I've answered the comment about the missing lock: that lock is only
 used to protect onion keys, which clients don't have.

 Thanks!

 Can we add some comments that document this information?

 init_keys_common() and init_keys_client() don't have function comments,
 and init_keys_common() is a really confusing name for a relay-only
 function.

 Let's open another ticket?

 Otherwise the changes look good here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33414#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs