[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32301 [Applications/Tor Browser]: Update Tor GeoIp Files for Android
#32301: Update Tor GeoIp Files for Android
----------------------------------------------+---------------------------
Reporter: sisbell | Owner: tbb-team
Type: defect | Status: closed
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution: duplicate
Keywords: tbb-mobile, TorBrowserTeam202004 | Actual Points:
Parent ID: | Points: .25
Reviewer: | Sponsor:
----------------------------------------------+---------------------------
Changes (by sysrqb):
* status: new => closed
* resolution: => duplicate
Comment:
Replying to [comment:3 sisbell]:
> Replying to [comment:2 sysrqb]:
> > As mentioned in #30518, we don't use GeoIP on Android. Tor currently
has the default:
> > {{{
> > V(GeoIPFile, FILENAME,
> > SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip"),
> > V(GeoIPv6File, FILENAME,
> > SHARE_DATADIR PATH_SEPARATOR "tor" PATH_SEPARATOR "geoip6"),
> > }}}
> >
> > and the current tor binary does not override the default
SHARE_DATADIR, so tor will only find the GeopIPFiles if they are in
`/usr/local/share/tor/geoip` (which will never be the case on Android).
>
> In the case of setting exit nodes, we use the controlConnection. Does
setting the geoIp file also not work through the control connection? If it
does work, we can still support geoIp.
>
>
> {{{
> controlConnection.setConf("GeoIPFile",
config.getGeoIpFile().getCanonicalPath());
> controlConnection.setConf("GeoIPv6File",
config.getGeoIpv6File().getCanonicalPath
> ());
> }}}
>
Ah! I missed that. Thanks for pointing that out. I don't know of a reason
why that wouldn't work.
Let's resolve this in #28766.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32301#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs