[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #29686 [Circumvention/BridgeDB]: filenames conflict on case-insensitive filesystems
#29686: filenames conflict on case-insensitive filesystems
--------------------------------------+-------------------------------
Reporter: catalyst | Owner: phw
Type: defect | Status: closed
Priority: Medium | Milestone:
Component: Circumvention/BridgeDB | Version:
Severity: Normal | Resolution: fixed
Keywords: ex-sponsor-19, s30-o24a4 | Actual Points: 0.7
Parent ID: #31281 | Points: 0.5
Reviewer: cohosh | Sponsor: Sponsor30-can
--------------------------------------+-------------------------------
Changes (by phw):
* status: merge_ready => closed
* resolution: => fixed
* actualpoints: => 0.7
Comment:
Replying to [comment:6 cohosh]:
> Only one minor comment:
> - It looks like the `Bridge` class
[https://github.com/NullHypothesis/bridgedb/compare/develop...defect/29686?expand=1
#diff-8139a954d554326b0bd0a384205521f3R297 here] should be in
`bridgedb.bridges.Bridge`? There's not `Bridge` class in
`bridgedb.bridgerings`.
>
> Otherwise, this looks good to me!
[[br]]
Oh, good catch! I fixed the issue and
[https://gitweb.torproject.org/bridgedb.git/commit/?h=develop&id=7afbe7e2866c7628bc5e40b15618105843486c80
merged branch defect/29686].
This fix took a bit longer than expected because it broke a unit test that
seems to have relied on the alphabetic ordering of unit tests – which we
changed in this patch.
[https://gitweb.torproject.org/user/phw/bridgedb.git/commit/?h=develop&id=8105032e2ab876d1c7d31471b828a0690f2bf6f3
Giving BridgeDB a bit more time to start] should have fixed this issue.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29686#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs