[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

#31634: Check .may_include order and tor subsystem init order are compatible
--------------------------------------+------------------------------------
 Reporter:  teor                      |          Owner:  nickm
     Type:  enhancement               |         Status:  merge_ready
 Priority:  Medium                    |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor              |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  diagnostics, practracker  |  Actual Points:  1
Parent ID:                            |         Points:  2
 Reviewer:  teor                      |        Sponsor:
--------------------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:19 nickm]:
 > Relpath wasn't quite right -- it wants to look at the actual filesystem
 and we didn't want that.

 If you pass "start" to relpath(), it shouldn't look at the filesystem at
 all:
 "This is a path computation: the filesystem is not accessed to confirm the
 existence or nature of path or start."
 https://docs.python.org/3/library/os.path.html#os.path.relpath

 > I went with a harsher approach, and now CI is passing

 Great! The new code looks good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31634#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs