[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31699 [Core Tor/Tor]: Remove unused configure.ac checks
#31699: Remove unused configure.ac checks
--------------------------+------------------------------------
Reporter: nickm | Owner: (none)
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: easy | Actual Points:
Parent ID: #31698 | Points:
Reviewer: catalyst | Sponsor:
--------------------------+------------------------------------
Changes (by catalyst):
* status: needs_review => needs_revision
Comment:
Replying to [comment:9 bduszel]:
> Hi catalyst, thanks for the review.
>
> I pushed the branch without libcap changes. I also added one more commit
- creation of "changes" file for this ticket.
>
> MR is already updated, please let me know if I should change anything
more.
>
> Thanks!
>
> MR: MR: https://github.com/torproject/tor/pull/1835
Thanks for the revisions! Mostly looks good.
There are some minor issues with the changes file, found by `make check-
changes`. Please let me know if you want help with fixing it up yourself,
or if you'd rather we do it for you. As a starting point, you might want
to look at doc/HACKING/CodingStandards.md, scripts/maint/lintChanges.py,
and the existing ChangeLog file.
{{{
./changes/ticket31699:
bug number 31699 does not appear
Unrecognized header: 'Minor cleanup '
Makefile:21877: recipe for target 'check-changes' failed
make[1]: *** [check-changes] Error 1
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31699#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs