[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #33877 [Applications/Tor Browser]: Disable Samples and Regression tests For Libevent Build

#33877: Disable Samples and Regression tests For Libevent Build
--------------------------------------------+--------------------------
 Reporter:  sisbell                         |          Owner:  tbb-team
     Type:  defect                          |         Status:  closed
 Priority:  Medium                          |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam202004R  |  Actual Points:
Parent ID:  #28704                          |         Points:  .1
 Reviewer:  gk, boklm                       |        Sponsor:
--------------------------------------------+--------------------------
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:1 sisbell]:
 > I combined the configure_opt_project into this commit since it is needed
 as part of the configuration. I removed the android part which will be in
 #28765
 >
 >
 >    --disable-libevent-regress --disable-samples are for all projects
 now, so I just put them in the build file, as they don't need to be
 configurable per platform variant.

 There is no need for `configure_opt_project` to add the `--disable-
 libevent-regress --disable-samples` flags to `projects/libevent/build`. So
 I think it does not make sense to combine the `configure_opt_project`
 changes with this commit. Instead it should be a separate commit, or
 combined with the patch for #28765 (where `configure_opt_project` is
 needed).

 But in order to avoid another round of reviews, I moved the
 `configure_opt_project` changes myself from the #33877 patch to the #28765
 patch. I also fixed a typo in the commit message for #28765 (removing the
 `-` after `Bug`). This is now commits
 f4792f507d57583fce4f52afcb927076762653a1 (#33877) and
 06bb0f2d4c91d7ac60ae180297d3c0707a004199 (#28765) on master.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33877#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs