Re: [tor-bugs] #33892 [Applications/Tor Browser]: Add brandProductName to torbutton brand localization files

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#33892: Add brandProductName to torbutton brand localization files
--------------------------------------+-----------------------------------
 Reporter:  acat                      |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_information
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam202004      |  Actual Points:
Parent ID:  #33533                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+-----------------------------------
Changes (by mcs):

 * status:  needs_review => needs_information
 * keywords:  TorBrowserTeam202004R => TorBrowserTeam202004


Comment:

 Replying to [comment:1 acat]:
 > Patch in
 https://github.com/acatarineu/torbutton/commit/8205657aaa54fb438553ab715d6ea067e3668f3c

 It looks like you were not 100% consistent when copying the strings from
 `brandShortName` to `brandProductName`. The names do not match for these
 locales: fa, lt, ms, nl, zh-CN (note that for zh-CN, the existing product
 name strings are translated in the properties file but not in the dtd). Is
 that what you intended?

 Another approach would be to only update the en-US locale files; then our
 translators might take another look at the existing strings when they add
 a translation for `brandProductName`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33892#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs