Re: [tor-bugs] #33618 [Core Tor/Tor]: Add IPv6 Support to is_local_addr()

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#33618: Add IPv6 Support to is_local_addr()
------------------------------------------+--------------------------------
 Reporter:  kimimaro                      |          Owner:  kimimaro
     Type:  enhancement                   |         Status:  needs_revision
 Priority:  Medium                        |      Milestone:  Tor:
                                          |  0.4.4.x-final
Component:  Core Tor/Tor                  |        Version:
 Severity:  Normal                        |     Resolution:
 Keywords:  outreachy-ipv6 ipv6  prop312  |  Actual Points:
Parent ID:                                |         Points:  1
 Reviewer:  teor                          |        Sponsor:  Sponsor55-can
------------------------------------------+--------------------------------

Comment (by kimimaro):

 Here's the main guidelines I am using with regards to writing the unit
 tests: https://github.com/torproject/tor/pull/1825#issuecomment-604905534

 I have a question. Is this what I'm supposed to write in test_config.c?
 This is just a prototype of course.


 {{{
 static void
 test_config_is_local_addr_impl(void *arg)
 {
   (void)arg;
   const routerinfo_t *my_routerinfo = router_get_my_routerinfo();
   const tor_addr_t *my_ipv6_addr = NULL;

   if (my_routerinfo) {
     my_ipv6_addr = &my_routerinfo->ipv6_addr;
   }

   // add test cases here like
 https://github.com/torproject/tor/blob/384a771fccb0b0ab8b95122815b33ef26bf042e8/src/test/test_addr.c#L345

   done:
     // free memory
 }

 // add this function into config_tests_t[]

 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33618#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs