[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

#32027: Bump version of Go to 1.13+
-------------------------------------------------+-------------------------
 Reporter:  cohosh                               |          Owner:  boklm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  snowflake, tbb-rbm,                  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004R,     |
  TorBrowserTeam202004R                          |
Parent ID:  #31688                               |         Points:  2
 Reviewer:  sysrqb                               |        Sponsor:
                                                 |  Sponsor58
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  snowflake, tbb-rbm, ReleaseTrainMigration,
     TorBrowserTeam202004 =>
     snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004R,
     TorBrowserTeam202004R
 * status:  assigned => needs_review


Comment:

 Replying to [comment:10 dcf]:
 > The `GOMODULE111=off` setting still works in go1.13 to disable the
 modules mode and work in the rbm setup. I had to do that in a branch
 recently where an upgraded quic-go required an upgraded go1.13.
 >  * https://gitweb.torproject.org/user/dcf/tor-browser-
 build.git/commit/?h=snowflake-turbotunnel-
 quic&id=981a62b0f0d61c9151ff1a76a79a78eb2ab3a8fc
 > It definitely does not work by default if you don't set
 `GOMODULE111=off`. You get a lot of errors like:
 > {{{
 > go: github.com/kr/pty@v1.1.1: Get
 https://proxy.golang.org/github.com/kr/pty/@v/v1.1.1.mod: \
 > dial tcp: lookup proxy.golang.org on 173.255.243.5:53: dial udp
 173.255.243.5:53: \
 > connect: network is unreachable
 > }}}

 That's a good idea, thanks. It makes we nervous that we are still using an
 old and unsupported Go version, so I picked it up: `bug_32037_V2`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32027_v2&id=e50ba24bb7445986df3c2ebac1fb02b75569b86d)

 I verified that both `obfs4` and `snwoflake` are still compiling on all
 supported platforms. (`meek` compiles at least for Linux x86_64 and
 Android armv7) Furthermore I tested bundles on Linux and an armv7 device
 and nothing exploded. Finally, I compared artifacts and it seems Go
 1.13.10 is not introducing any reproducibility issues. Thus, I think it's
 ready for review and testing in the next alpha (I did not jump to 1.14
 immediately as we are late in the alpha process for 9.5, so we might want
 to be a bit careful at this point).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32027#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs