[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+

#32027: Bump version of Go to 1.13+
-------------------------------------------------+-------------------------
 Reporter:  cohosh                               |          Owner:  boklm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  snowflake, tbb-rbm,                  |  Actual Points:
  ReleaseTrainMigration, GeorgKoppen202004,      |
  TorBrowserTeam202004R                          |
Parent ID:  #31688                               |         Points:  2
 Reviewer:  sysrqb                               |        Sponsor:
                                                 |  Sponsor58
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_revision => needs_review
 * keywords:
     snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004,
     TorBrowserTeam202004
     =>
     snowflake, tbb-rbm, ReleaseTrainMigration, GeorgKoppen202004,
     TorBrowserTeam202004R


Comment:

 Replying to [comment:19 gk]:
 > Replying to [comment:18 boklm]:
 > > Should we remove the workaround we have in `projects/obfs4/build` and
 `projects/snowflake/build` (removing the files `go.mod` and `go.sum`) if
 setting `GOMODULE111=off` makes that not needed?
 >
 > We can do that, good idea. Let me try this tomorrow and push a better
 branch if that works.

 Okay, some further digging. Yes, we can remove our previous workaround for
 the missing support for Go modules. But only if we set `GO111MODULE=off`
 in the `obfs4` and `snowflake` build scripts instead (too). I am not sure
 what's been causing this but for some reason a `go.sum` file in one of the
 PT *deps* was no issue with 1.12.x but is with 1.13.x now (which is what
 dcf was hitting).

 `bug_32027_v3` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32027_v3&id=81dd92051328e23ae7b02354fb84450905c62b52)
 contains the fixups.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32027#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs