[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32027 [Applications/Tor Browser]: Bump version of Go to 1.13+
#32027: Bump version of Go to 1.13+
-------------------------------------------------+-------------------------
Reporter: cohosh | Owner: boklm
Type: defect | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: snowflake, tbb-rbm, | Actual Points:
ReleaseTrainMigration, GeorgKoppen202004, |
TorBrowserTeam202004R |
Parent ID: #31688 | Points: 2
Reviewer: sysrqb | Sponsor:
| Sponsor58
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:21 cypherpunks]:
> > But only if we set GO111MODULE=off in the obfs4 and snowflake build
scripts instead (too).
> Move it to https://gitweb.torproject.org/user/gk/tor-browser-
build.git/tree/projects/go/config?h=bug_32027_v3&id=81dd92051328e23ae7b02354fb84450905c62b52#n20
instead?
I am not sure. Not everything that uses the setup part does need that env
variable set. So, I am inclined to just apply it where it is needed. But
that can probably be said for the `build_go_lib` part, too. I guess I am
fine making that change if we think that's good. So far we kept the
workaround for the lack of go module support in the respective projects
which is why I added the env variable there as well.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32027#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs