[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder
#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
------------------------------------+--------------------------------
Reporter: phw | Owner: agix
Type: defect | Status: needs_revision
Priority: Medium | Milestone:
Component: Circumvention/BridgeDB | Version:
Severity: Normal | Resolution:
Keywords: s30-o22a2 | Actual Points:
Parent ID: #31279 | Points: 1
Reviewer: | Sponsor: Sponsor30-can
------------------------------------+--------------------------------
Changes (by phw):
* status: needs_review => needs_revision
Comment:
With "push your patch to GitHub," I meant pushing the commits that your
patch is based on.
That said, here's some feedback:
* Overall, the `get_payload()` approach seems reasonable. Nicely done!
* Make sure that your code is based on the develop and not on the master
branch. For BridgeDB, we're using [https://nvie.com/posts/a-successful-
git-branching-model/ a development model] in which patches branch off of
develop rather than master.
* I'm not sure why the patch deletes `TRANSPORT_PATTERN` and
`UNBLOCKED_PATTERN`, and replaces them with a TODO item?
* The patch's commit message should provide a short summary of how the
patch accomplishes its goal. [https://git-scm.com/book/en/v2/Distributed-
Git-Contributing-to-a-Project#Commit-Guidelines Here's a summary] of how
to write good commit messages.
* We should add unit tests to make sure that the patch correctly deals
with emails of different content types.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33835#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs