[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #33973 [Applications/Tor Browser]: Create fat .aar for geckoview

#33973: Create fat .aar for geckoview
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  task                                 |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm,                 |  Actual Points:
  TorBrowserTeam202004, GeorgKoppen202004        |
Parent ID:  #33626                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by boklm):

 An other option is using a separate `step` in `projects/geckoview/config`
 to merge the .aar files. In `projects/geckoview/config` we would add
 something like this:
 {{{
 steps:
   merge_aars:
     merge_aars: |
       #!/bin/bash
       # commands to merge .aar files

     input_files:
       - name: geckoview_armv7
         project: geckoview
         pkg_type: build
         target_prepend: torbrowser-android-armv7
       - name: geckoview_aarch64
         project: geckoview
         pkg_type: build
         target_prepend: torbrowser-android-aarch64
 }}}

 And in `projects/fenix/config` we would have something like this:
 {{{
 input_files:
  - name: geckoview
    project: geckoview
    pkg_type: merge_aars
 }}}

 In `rbm.conf` we also need to set
 `var/container/disable_network/merge_aars` to prevent network access
 during the `merge_aars` step.

 Then we can use the following command to build geckoview for a single
 arch:
 {{{
 ./rbm/rbm build geckoview --target nightly --target torbrowser-android-
 x86_64
 }}}
 Or this command to build it for all archs and merge them:
 {{{
 ./rbm/rbm build geckoview --step merge_aars --target nightly --target
 torbrowser-android-all
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33973#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs