[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32418 [Applications/Tor Browser]: Torbrowser tells on every start, that it can't update although it is newest



#32418: Torbrowser tells on every start, that it can't update although it is newest
----------------------------------------------+----------------------------
 Reporter:  Yeti                              |          Owner:  mcs
     Type:  defect                            |         Status:
                                              |  needs_review
 Priority:  Medium                            |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-update,TorBrowserTeam202004R  |  Actual Points:  1.7
Parent ID:                                    |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------

Comment (by mcs):

 Replying to [comment:16 sysrqb]:
 > Is there a reason for not using `MOZ_PROXY_BYPASS_PROTECTION` instead of
 defining a new `JSON_POLICIES_ONLY`? The latter is definitely more
 explicit about why it is defined, so I see some benefit for us in using
 `JSON_POLICIES_ONLY`, but I wonder if there is another reason as well.

 Kathy and I think using `MOZ_PROXY_BYPASS_PROTECTION` is a good idea; we
 just did not think to do so when we wrote the patch.  Do you want us to
 create a fixup or do you want to take care of it?

 We could even do something like the following if we want to continue to
 use `JSON_POLICIES_ONLY` within that file for readability:
  #define JSON_POLICIES_ONLY MOZ_PROXY_BYPASS_PROTECTION

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32418#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs