[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33576 [Applications/Tor Browser]: Update pion-webrtc version to 2.2.3
#33576: Update pion-webrtc version to 2.2.3
----------------------------------------------+----------------------------
Reporter: cohosh | Owner: tbb-team
Type: defect | Status:
| needs_information
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: snowflake, TorBrowserTeam202004R | Actual Points:
Parent ID: | Points:
Reviewer: boklm | Sponsor:
----------------------------------------------+----------------------------
Comment (by cohosh):
Replying to [comment:10 sysrqb]:
> And bumping `webrtc` to `v2.2.3` is the purpose of this ticket, so
that's all...fine :) However, I wonder why `go mod graph` (or the script)
think `v2.1.2` is the/a new dependency version. Do you know?
That's just a typo on part I think. The commit has matches `v2.2.3`. Sorry
about that. It wasn't generated by gomodtorbm since it's the root library
we're updating.
>
> Second, do you know where the `crypto` commit hash bump came from? Was
that a manual change you did? I found that hash on the `master` branch, so
I don't have a problem with using it (I see the current commit we're using
is pretty old).
Hmm. Looks like it was bumped
[https://github.com/pion/webrtc/commit/efe2c58d4e49fd56578219b73902a89c1d1b7b22
here].
But this isn't even the most recent version bump for `v2.2.3`. And now
that I'm looking at it, gomodtorbm should've ignored that project.
Perhaps we shouldn't update it to be on the safe side.
I'll make these changes.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33576#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs