[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #1780 [Tor - Torctl]: Unknown exceptions caught in TorCtl.Connection.read_routers

#1780: Unknown exceptions caught in TorCtl.Connection.read_routers
-------------------+--------------------------------------------------------
 Reporter:  hbock  |        Type:  defect      
   Status:  new    |    Priority:  normal      
Milestone:         |   Component:  Tor - Torctl
  Version:         |    Keywords:              
   Parent:         |  
-------------------+--------------------------------------------------------
 Any exceptions that aren't caught in the try block in
 Connection.read_routers are printed using the traceback module and
 ignored.  This causes problems when an exception occurs every time
 get_router is called (e.g., TorCtlClosed), leading to traceback explosion.

 Patch attached that removes the except: catch-all, as it seems much better
 to just let it unwind to the caller.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1780>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs