[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1653 [Tor - Relay]: exit relays don't consider local cell queue when hearing sendme

#1653: exit relays don't consider local cell queue when hearing sendme
-------------------------+--------------------------------------------------
 Reporter:  arma         |       Owner:                    
     Type:  defect       |      Status:  needs_review      
 Priority:  normal       |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor - Relay  |     Version:                    
 Keywords:               |      Parent:                    
-------------------------+--------------------------------------------------

Comment(by nickm):

 The patch looks good to me.  I'd change the implementation on
 circuit_queue_high() so that instead of checking for "queue->n >=
 HIGHWATER" it checks for "streams_blocked && queue->n >= LOWWATER".  Being
 above the high-water mark is the condition to block, but the condition to
 resume is getting under the low-water mark again.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1653#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs