[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1102 [Tor - Relay]: Queuing v3 signature for next consensus, an hour later?



#1102: Queuing v3 signature for next consensus, an hour later?
--------------------------+-------------------------------------------------
  Reporter:  arma         |       Owner:  nickm             
      Type:  defect       |      Status:  assigned          
  Priority:  minor        |   Milestone:  Tor: 0.2.2.x-final
 Component:  Tor - Relay  |     Version:  0.2.1.19          
Resolution:  None         |    Keywords:                    
    Parent:               |  
--------------------------+-------------------------------------------------

Old description:

> On moria1, which I started at
> Sep 21 01:51:04.434 (after some parts of the consensus generation were
> supposed to start)
>
> Sep 21 01:51:47.809 [notice] Uploaded a vote to dirserver
> 128.31.0.34:9031
> Sep 21 01:51:47.832 [notice] Uploaded a vote to dirserver
> 216.224.124.114:9030
> Sep 21 01:51:47.833 [notice] Uploaded a vote to dirserver
> 208.83.223.34:443
> Sep 21 01:51:48.045 [notice] Uploaded a vote to dirserver 86.59.21.38:80
> Sep 21 01:51:48.311 [notice] Uploaded a vote to dirserver
> 194.109.206.212:80
> Sep 21 01:51:49.618 [notice] Uploaded a vote to dirserver 213.73.91.31:80
> Sep 21 01:51:49.662 [notice] Uploaded a vote to dirserver
> 80.190.246.100:80
> ...
> Sep 21 01:52:31.466 [notice] Time to fetch any votes that we're missing.
> Sep 21 01:52:31.466 [notice] We're missing votes from 6 authorities.
> Asking every other authority for a copy.
> ...
> Sep 21 01:55:01.379 [notice] Time to compute a consensus.
> Sep 21 01:55:01.586 [notice] Consensus computed; uploading signature(s)
> Sep 21 01:55:01.587 [notice] Signature(s) posted.
> Sep 21 01:55:01.611 [notice] Got a signature from 128.31.0.34. Adding it
> to the pending consensus.
> Sep 21 01:55:01.612 [notice] Uploaded signature(s) to dirserver
> 128.31.0.34:9031
> Sep 21 01:55:01.763 [notice] Uploaded signature(s) to dirserver
> 216.224.124.114:9030
> Sep 21 01:55:01.770 [notice] Uploaded signature(s) to dirserver
> 208.83.223.34:443
> Sep 21 01:55:01.846 [notice] Uploaded signature(s) to dirserver
> 86.59.21.38:80
> Sep 21 01:55:01.854 [notice] Got a signature from 86.59.21.38. Adding it
> to the pending consensus.
> Sep 21 01:55:01.930 [notice] Uploaded signature(s) to dirserver
> 194.109.206.212:80
> Sep 21 01:55:01.934 [notice] Got a signature from 194.109.206.212. Adding
> it to the pending consensus.
> Sep 21 01:55:02.827 [notice] Got a signature from 208.83.223.34. Adding
> it to the pending consensus.
> Sep 21 01:55:02.869 [notice] Got a signature from 216.224.124.114. Adding
> it to the pending consensus.
> Sep 21 01:55:05.121 [notice] Got a signature from 213.73.91.31. Adding it
> to the pending consensus.
> Sep 21 01:55:05.675 [notice] Uploaded signature(s) to dirserver
> 213.73.91.31:80
> Sep 21 01:55:08.879 [notice] Got a signature from 80.190.246.100. Adding
> it to the pending consensus.
> Sep 21 01:55:09.307 [notice] Uploaded signature(s) to dirserver
> 80.190.246.100:80
> Sep 21 01:57:31.840 [notice] Time to fetch any signatures that we're
> missing.
> Sep 21 02:00:01.204 [notice] Time to publish the consensus and discard
> old votes
> Sep 21 02:00:01.231 [notice] Choosing expected valid-after time as
> 2009-09-21 07:00:00: consensus_set=1, interval=3600
> Sep 21 02:00:01.300 [notice] Consensus published.
> Sep 21 02:00:01.301 [notice] Choosing expected valid-after time as
> 2009-09-21 07:00:00: consensus_set=1, interval=3600
> Sep 21 02:00:09.474 [notice] Got a signature from 38.229.70.2. Queuing it
> for the next consensus.
>
> It's that last line that concerns me. Queuing for the next consensus
> that's 59 minutes
> and 50 seconds from now? Shouldn't we either be adding it to the current
> consensus even
> though it's late, or discarding it because it's late?
>
> (Note that this isn't from an authority that moria1 recognizes)
>
> [Automatically added by flyspray2trac: Operating System: All]

New description:

 On moria1, which I started at
 Sep 21 01:51:04.434 (after some parts of the consensus generation were
 supposed to start)

 Sep 21 01:51:47.809 [notice] Uploaded a vote to dirserver 128.31.0.34:9031
 Sep 21 01:51:47.832 [notice] Uploaded a vote to dirserver
 216.224.124.114:9030
 Sep 21 01:51:47.833 [notice] Uploaded a vote to dirserver
 208.83.223.34:443
 Sep 21 01:51:48.045 [notice] Uploaded a vote to dirserver 86.59.21.38:80
 Sep 21 01:51:48.311 [notice] Uploaded a vote to dirserver
 194.109.206.212:80
 Sep 21 01:51:49.618 [notice] Uploaded a vote to dirserver 213.73.91.31:80
 Sep 21 01:51:49.662 [notice] Uploaded a vote to dirserver
 80.190.246.100:80
 ...
 Sep 21 01:52:31.466 [notice] Time to fetch any votes that we're missing.
 Sep 21 01:52:31.466 [notice] We're missing votes from 6 authorities.
 Asking every other authority for a copy.
 ...
 Sep 21 01:55:01.379 [notice] Time to compute a consensus.
 Sep 21 01:55:01.586 [notice] Consensus computed; uploading signature(s)
 Sep 21 01:55:01.587 [notice] Signature(s) posted.
 Sep 21 01:55:01.611 [notice] Got a signature from 128.31.0.34. Adding it
 to the pending consensus.
 Sep 21 01:55:01.612 [notice] Uploaded signature(s) to dirserver
 128.31.0.34:9031
 Sep 21 01:55:01.763 [notice] Uploaded signature(s) to dirserver
 216.224.124.114:9030
 Sep 21 01:55:01.770 [notice] Uploaded signature(s) to dirserver
 208.83.223.34:443
 Sep 21 01:55:01.846 [notice] Uploaded signature(s) to dirserver
 86.59.21.38:80
 Sep 21 01:55:01.854 [notice] Got a signature from 86.59.21.38. Adding it
 to the pending consensus.
 Sep 21 01:55:01.930 [notice] Uploaded signature(s) to dirserver
 194.109.206.212:80
 Sep 21 01:55:01.934 [notice] Got a signature from 194.109.206.212. Adding
 it to the pending consensus.
 Sep 21 01:55:02.827 [notice] Got a signature from 208.83.223.34. Adding it
 to the pending consensus.
 Sep 21 01:55:02.869 [notice] Got a signature from 216.224.124.114. Adding
 it to the pending consensus.
 Sep 21 01:55:05.121 [notice] Got a signature from 213.73.91.31. Adding it
 to the pending consensus.
 Sep 21 01:55:05.675 [notice] Uploaded signature(s) to dirserver
 213.73.91.31:80
 Sep 21 01:55:08.879 [notice] Got a signature from 80.190.246.100. Adding
 it to the pending consensus.
 Sep 21 01:55:09.307 [notice] Uploaded signature(s) to dirserver
 80.190.246.100:80
 Sep 21 01:57:31.840 [notice] Time to fetch any signatures that we're
 missing.
 Sep 21 02:00:01.204 [notice] Time to publish the consensus and discard old
 votes
 Sep 21 02:00:01.231 [notice] Choosing expected valid-after time as
 2009-09-21 07:00:00: consensus_set=1, interval=3600
 Sep 21 02:00:01.300 [notice] Consensus published.
 Sep 21 02:00:01.301 [notice] Choosing expected valid-after time as
 2009-09-21 07:00:00: consensus_set=1, interval=3600
 Sep 21 02:00:09.474 [notice] Got a signature from 38.229.70.2. Queuing it
 for the next consensus.

 It's that last line that concerns me. Queuing for the next consensus
 that's 59 minutes
 and 50 seconds from now? Shouldn't we either be adding it to the current
 consensus even
 though it's late, or discarding it because it's late?

 (Note that this isn't from an authority that moria1 recognizes)

 [Automatically added by flyspray2trac: Operating System: All]

--

Comment(by nickm):

 On the bright side: This will not hurt anything major.  We can only get
 this message if we have no pending consensus, meaning that either we have
 nothing to add it to yet, or if we have made a complete consensus, which
 is only possible if we got enough signatures from others.

 On the un-bright side: we will indeed hang on to this detached signature
 document till the next round of voting, at which point we will try to add
 it to the consensus, then drop it because it doesn't apply.  Really, we
 should try adding it to our existing consensus.  Sadly, I don't think
 there's a function for that.  Refactoring may be needed.

 I am not sure this is critical for 0.2.2.x.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1102#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs