Re: [tor-bugs] #1746 [Tor - Relay]: Allow statistics options to be changed without restarting Tor

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#1746: Allow statistics options to be changed without restarting Tor
-------------------------+--------------------------------------------------
 Reporter:  Sebastian    |       Owner:              
     Type:  defect       |      Status:  needs_review
 Priority:  normal       |   Milestone:              
Component:  Tor - Relay  |     Version:              
 Keywords:               |      Parent:              
-------------------------+--------------------------------------------------

Comment(by karsten):

 Replying to [comment:11 nickm]:
 > > We might further move the exit port statistics code in rephist.c after
 rep_hist_free_all() and before cell statistics. Should we do that as a
 separate commit logically preceding this patch?
 >
 > The order doesn't greatly matter, but adding another patch to clean up
 code would always be neat.

 Added a patch for that.

 > > We don't collect data for more than 1 interval anymore, but only for
 complete 24 hour intervals
 >
 > This is a new change with this patch, or an old change?  And if it's a
 new change with this patch, what's the rationale?  (If it was an old
 change, do you remember why we did it?)

 It's an old change (see commit 54c97c91). The rationale is that we might
 give out too much information by reporting values for smaller intervals
 than 24 hours. If you compare the values of request periods 1 to N to the
 values of periods 2 to N (after period 1 got dropped), you can derive the
 values of period 1. The other reason is that we are fine with daily
 updated stats, so we should collect just those data.

 > > Should we separate the code refactoring parts from the bugfixing
 parts?
 >
 > In the future, yes: it's way easier to review a commit if you know "this
 commit isn't supposed to change functionality."  For this patch, it
 probably isn't necessary, since we've already been reviewing it.

 Okay, leaving this as it is.

 See branches stats_v4 and stats_v4_rebased in my public repository. The
 first branch moves around the exit stats code, whereas the second branch
 further rebases everything to master and squashes my original patch with
 my minor changes.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1746#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs