[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #911 [Tor Relay]: Authorities assign Running flag to hibernating relays?
#911: Authorities assign Running flag to hibernating relays?
--------------------------------+-------------------------------------------
Reporter: arma | Type: defect
Status: needs_review | Priority: minor
Milestone: Tor: 0.2.2.x-final | Component: Tor Relay
Version: 0.2.0.31 | Resolution: None
Keywords: | Parent:
--------------------------------+-------------------------------------------
Comment(by arma):
A) Should we put the AssumeReachable check above the
router->is_hibernating check?
On the one hand, AssumeReachable is supposed to trump things like whether
the relay is reachable. On the other hand, if it publishes a hibernating
descriptor, it means it really doesn't want to be used. So I am ok with
either way. Therefore I am ok with the current way.
B) Should we allow for any skew here? What if the router has a clock
that's 5 minutes off, so it publishes a descriptor for 5 minutes in the
future, and we test it three minutes in. In this edge case, we will
continue to advertise it as Running for the full 45 minute period. Not the
end of the world. On the other hand, if we check with a skew of 5 or 10
minutes, the only false positive is the case where we did the reachability
test shortly before the hibernation descriptor showed up. Also not so bad.
More generally, if the last descriptor we have from the router is a
hibernation descriptor, what do we care about our reachability tests? That
approach would resolve Sebastian's point about bug 919 too. Once we get a
new descriptor that doesn't claim it's hibernating, we can resume checking
then (see commit 4f307e038272).
C) The elses with two lines after them but no { } make me uncomfortable. I
know one of them is a comment, so technically it's correct, but still. :)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/911#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs