Re: [tor-bugs] #1825 [Tor Relay]: Add unit tests for statistics code

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#1825: Add unit tests for statistics code
--------------------------+-------------------------------------------------
  Reporter:  karsten      |       Owner:        
      Type:  defect       |      Status:  closed
  Priority:  normal       |   Milestone:        
 Component:  Tor Relay    |     Version:        
Resolution:  implemented  |    Keywords:        
    Parent:               |  
--------------------------+-------------------------------------------------
Changes (by nickm):

  * status:  needs_review => closed
  * resolution:  => implemented


Comment:

 Looks good to me...  just a couple things.

 * It seems that there's still a few rep_hist_exit_stats_history calls in
 test.c that didn't get renamed.
 * There wasn't a changes file.
 * Apparently the way we handled cleaning up temporary directories with
 atexit() meant that when the child process exited, it would remove the
 temporary directory, thus making other tests in the main process fail.

 I'm  fixing up those and merging it.  Thanks!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1825#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs