[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #1042 [Tor Relay]: rate-limit MaxOnionsPending warns
#1042: rate-limit MaxOnionsPending warns
--------------------------------+-------------------------------------------
Reporter: arma | Type: defect
Status: needs_review | Priority: minor
Milestone: Tor: 0.2.2.x-final | Component: Tor Relay
Version: 0.2.1.19 | Resolution: None
Keywords: easy | Parent:
--------------------------------+-------------------------------------------
Comment(by Sebastian):
I think you mean <= instead of >= in this line, otherwise this never
triggers:
{{{
+ if (lim->rate + lim->last_allowed >= now) {
}}}
Also I'd make rate_limit_is_ready() static. It can't be used to peek how
many log messages where generated so far and for logging purposes
rate_limit_log() should be entirely sufficient.
For the interval that is used to ratelimit onionskin handoff messages, we
should probably use WARN_TOO_MANY_CONNS_INTERVAL, or is there a reason why
you want it to log more often?
Other than that, looks good to me.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1042#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs