[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6524 [Tor Client]: [PATCH] move to non-recursive make

#6524: [PATCH] move to non-recursive make
-------------------------+--------------------------------------------------
 Reporter:  stewart      |          Owner:  stewart         
     Type:  enhancement  |         Status:  new             
 Priority:  normal       |      Milestone:                  
Component:  Tor Client   |        Version:  Tor: unspecified
 Keywords:               |         Parent:                  
   Points:               |   Actualpoints:                  
-------------------------+--------------------------------------------------

Comment(by nickm):

 Hm. This could be to review, since the diff renames the files *and*
 changes their contents. Next time, it would be easier to do renames and
 changes separate commits, so I can look at just the changes.  No need to
 change it this time though.

 I tried applying the first version patch to master, and it complained
 about .deps files when I did make; it looks like the transition isn't 100%
 clean, and people will need to be told to do a "git clean -xf; autogen.sh"
 before they proceed.  That's ok.

 Why did the src_test_*.o files get made with long_prefixes while others
 did't?

 Then I tried the second two versions of the patches, and when I did "sh
 autogen.sh", I got:
 {{{
 [1134]$ sh autogen.sh
 autoreconf: Entering directory `.'
 autoreconf: configure.in: not using Gettext
 autoreconf: running: aclocal --force
 autoreconf: configure.in: tracing
 autoreconf: configure.in: not using Libtool
 autoreconf: running: /usr/bin/autoconf --force
 autoreconf: running: /usr/bin/autoheader --force
 autoreconf: running: automake --add-missing --copy --force-missing
 configure.in:1318: required file `contrib/Makefile.in' not found
 configure.in:1318: required file `contrib/suse/Makefile.in' not found
 autoreconf: automake failed with exit status: 1
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6524#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs