Re: [tor-bugs] #6631 [Stem]: Caching expansion and test prompt

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#6631: Caching expansion and test prompt
-------------------------+--------------------------------------------------
 Reporter:  atagar       |          Owner:  neena         
     Type:  enhancement  |         Status:  needs_revision
 Priority:  normal       |      Milestone:                
Component:  Stem         |        Version:                
 Keywords:               |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by neena):

  * status:  needs_review => needs_revision


Comment:

 Replying to [ticket:6631 atagar]:
 > Code review for a couple new features. Initially I was planning to
 simply add caching for GETCONF and SETCONF requests, but ended up making a
 few other changes on the way.

 Looks fine.

 I would've preferred adding the \n to STOP_CONFIRMATION here.

 > +      print
 > +      response = raw_input(STOP_CONFIRMATION)

 and typo here.

 > +def start():
 > +  """
 > +  Starts up a tor instance that we can attach a contorller to.
 > +  """


 That's all.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6631#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs