[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4620 [Tor Relay]: Move ipv6_preferred from routerinfo_t to node_t

#4620: Move ipv6_preferred from routerinfo_t to node_t
-----------------------+----------------------------------------------------
 Reporter:  ln5        |          Owner:  ln5               
     Type:  defect     |         Status:  assigned          
 Priority:  minor      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:  ipv6       |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by ln5):

 Please comment on bug4620_hackery in my repo. Still not ready for
 merging -- lacks a changes file and good committ message(s) if nothing
 else. I'd like to know if this is what we want first.

 Addressing Nicks comments he gave on IRC yesterday:

 - Making node_assert_ok() it into a function would require that
   __func__ and such would be passed to it, wouldn't it? Keeping it a
   macro and using the tor_assert() macro seems risky, f.ex. because
   'n' would be evaluated twice. Moved it to nodelist.h as is.

 - Kept extend_info_from_router(), made it static and removed the now
   unused second arg. Does this make more sense?

 - Complemented get_configured_bridge_by_addr_port_digest() with
   get_configured_bridge_by_orports_digest() rather than replacing it.

 - Moved node_* to nodelist.[ch]. Should node_describe(),
   format_node_description() and node_get_description() move too?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4620#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs