[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #8292 [Firefox Patch Issues]: Alter behavior of getFirstPartyURI and consumers
#8292: Alter behavior of getFirstPartyURI and consumers
----------------------------------------------+-----------------------------
Reporter: mikeperry | Owner: mikeperry
Type: enhancement | Status: needs_review
Priority: major | Milestone:
Component: Firefox Patch Issues | Version:
Keywords: tbb-linkability, MikePerry201307 | Parent:
Points: | Actualpoints:
----------------------------------------------+-----------------------------
Changes (by mcs):
* status: needs_revision => needs_review
Comment:
Revised patch posted. Our testing hasn't revealed any problems, but more
field testing would be good. Here are the recent changes:
{{{
--- a/content/base/src/ThirdPartyUtil.cpp
+++ b/content/base/src/ThirdPartyUtil.cpp
@@ -329,19 +329,20 @@ ThirdPartyUtil::GetFirstPartyURI(nsIChannel
*aChannel,
// At this point, about: and chrome: URLs have been mapped to file:
or
// jar: URLs. Try to recover the original URL.
nsCAutoString scheme;
nsresult rv2 = (*aOutput)->GetScheme(scheme);
NS_ENSURE_SUCCESS(rv2, rv2);
if (scheme.Equals("file") || scheme.Equals("jar")) {
nsCOMPtr<nsIURI> originalURI;
rv2 = aChannel->GetOriginalURI(getter_AddRefs(originalURI));
- if (NS_SUCCEEDED(rv2) && originalURI)
+ if (NS_SUCCEEDED(rv2) && originalURI) {
NS_RELEASE(*aOutput);
NS_ADDREF(*aOutput = originalURI);
+ }
}
}
}
// If the channel was missing, closed or broken, try the
// window hierarchy directly.
//
// This might fail to work for first-party loads themselves, but
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8292#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs