[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9157 [BridgeDB]: Persian and Arabic should be right aligned on bridges.tpo

#9157: Persian and Arabic should be right aligned on bridges.tpo
---------------------------------+------------------------------------------
 Reporter:  runa                 |          Owner:  isis    
     Type:  task                 |         Status:  accepted
 Priority:  minor                |      Milestone:          
Component:  BridgeDB             |        Version:          
 Keywords:  RTL,translations,ui  |         Parent:          
   Points:                       |   Actualpoints:          
---------------------------------+------------------------------------------
Changes (by isis):

  * status:  needs_review => accepted
  * owner:  => isis


Comment:

 Replying to [comment:10 sysrqb]:
 > Replying to [comment:9 sysrqb]:
 > > Ok, slightly-less-hacky branch on bug9157_r2_rebase
 https://github.com/sysrqb/bridgedb.git
 >
 > That's actually kinda annoying (at least to me). See commit
 [https://github.com/sysrqb/bridgedb/commit/a31c592eadd72a659f22497f66e77fb90c6c207b
 a31c592eadd72a659f22497f66e77fb90c6c207b]
 >
 > (I also didn't whitespace-check it, don't shoot me!)

 Don't worry, I don't shoot accomplices. I just incessantly nag them about
 obsessive compulsive formatting divergences. :)

 Overall, this looks really good. One thing, and it's not that important,
 because overall the documentation is great, but just so that you don't
 have to dig through [http://sphinx-doc.org/domains.html#info-field-lists
 the Sphinx API documentation on parameter specifications]...the type of a
 `:param:` directive is specified like this:
 {{{
 :param str beach: The place with sand where you go to code and surf.
 }}}

 or like this if it has some weird type (like it's a class or something):
 {{{
 :type beach: :class:`sys.env.Beach`
 :param beach: The place with sand where you go to code and surf.
 }}}

 `:returns:` is the same:
 {{{
 :rtype: str
 :returns: Some string.
 }}}
 or
 {{{
 :rtype: :class:`sys.env.Beach`
 :returns: That place with sand where you go to hack.
 }}}

 Also, I totally don't care for now, since I'm sure Sphinx would choke on a
 lot worse if I tried to generate docs from BridgeDB's code right now. :P

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9157#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs