[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8255 [Stem]: Parse exit list entry

#8255: Parse exit list entry
-------------------------+--------------------------------------------------
 Reporter:  atagar       |          Owner:  atagar      
     Type:  enhancement  |         Status:  needs_review
 Priority:  minor        |      Milestone:              
Component:  Stem         |        Version:              
 Keywords:               |         Parent:  #8252       
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------
Changes (by arlolra):

  * status:  needs_revision => needs_review


Comment:

 Thanks for the review.

 The spec does indeed say,
 {{{
 (ExitNode | Published | LastStatus | ExitAddress*)*
 }}}
 but it also says, `The document consists of an arbitrary number of entries
 each consisting of *four* or more lines.`
 and `*One* or more test results for this relay consisting of the found
 exit address and the time, in UTC, when the test was performed.`

 So, although it uses the regex star, I think it means plus.
 {{{
 (ExitNode | Published | LastStatus | ExitAddress+)*
 }}}

 Could you interpret it that way? Maybe we should get that updated?

 The rest of your comments were implemented. Again, see the squashed
 branch,
 https://github.com/arlolra/stem/compare/tordnsel

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8255#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs