[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #9349 [Flashproxy]: flashproxy facilitator: Allow clients to specify transports
#9349: flashproxy facilitator: Allow clients to specify transports
----------------------------+-------------------
Reporter: asn | Owner: dcf
Type: task | Status: new
Priority: normal | Milestone:
Component: Flashproxy | Version:
Resolution: | Keywords:
Actual Points: | Parent ID: #7167
Points: |
----------------------------+-------------------
Comment (by dcf):
Replying to [comment:9 asn]:
> For "release early; release often" purposes, I pushed a branch with
changes on the client-side applications to support pluggable transports
and the new client registrations.
>
> It can be found in `https://git.torproject.org/user/asn/flashproxy.git`
under branch `bug9349_client_side`. I've only briefly tested it.
Thanks George, you're awesome.
The `--help` test for `--transport` should say what the default value is.
Set
{{{
transport = DEFAULT_TRANSPORT
}}}
in the global options class, not in the code just before option parsing.
{{{
+ transport_part = [""] # default to empty string
}}}
I think that should rather be an empty list; otherwise I'm pretty sure the
helpers get an extra empty argument.
I saw you moved some duplicated code into a module flashproxy_reg_utils.
Please see #6810 for more about reducing code duplication. I'm afraid
doing it this way will break `make install`. Alexandre tried breaking out
a module in #6810, and it didn't quite work. So if you can separate the
deduplication part of the patch, I think it's better for the purpose of
this ticket.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9349#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs