[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11200 [Tor]: cached consensus inteferes with DisableNetwork=1

#11200: cached consensus inteferes with DisableNetwork=1
-------------------------+-------------------------------------------------
     Reporter:  mcs      |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  major    |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor      |    Version:  Tor: 0.2.4.21
   Resolution:           |   Keywords:  tor-client, 024-backport,
Actual Points:           |  025-triaged, andrea-review-0254, tbb-tor-
       Points:           |  backported-3.6b2, TorBrowserTeam201408
                         |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by arma):

 The patch looks good to me. I bet the Tor Browser people will want it,
 likely even for TB 3.6.4 that they're building now.

 To be thorough, there are two other cases where should_delay_dir_fetches()
 returns 1 so update_router_have_minimum_dir_info() sets have_min_dir_info
 to 0:

 * options->UseBridges and !any_bridge_descriptors_known():

 * options->UseBridges and pt_proxies_configuration_pending():

 And at first glance it seems like each of these also has edge cases where
 have_min_dir_info will get set to 0 and not recomputed when these cases
 change.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11200#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs