[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12664 [BridgeDB]: Newlines aren't preserved when bridges are copied to clipboard

#12664: Newlines aren't preserved when bridges are copied to clipboard
--------------------------+-----------------------------------------
     Reporter:  mttp      |      Owner:  isis
         Type:  defect    |     Status:  needs_revision
     Priority:  normal    |  Milestone:
    Component:  BridgeDB  |    Version:
   Resolution:            |   Keywords:  bridgedb-https, bridgedb-ui
Actual Points:            |  Parent ID:
       Points:            |
--------------------------+-----------------------------------------
Changes (by isis):

 * cc: isis (added)
 * status:  needs_review => needs_revision
 * keywords:   => bridgedb-https, bridgedb-ui


Comment:

 Replying to [comment:1 mttp]:
 > I've made a patch that I think corrects this issue.

 Hi mttp, thanks for the patch!

 One thing, however:

 Python code goes in `.py` files; Javascript in `.js` files; HTML in
 `.html` files. The HTML templates for the web interface are in
 `lib/bridgedb/templates`, and the spot that you want is
 [https://gitweb.torproject.org/bridgedb.git/blob/HEAD:/lib/bridgedb/templates/bridges.html#l17
 here]. However, you may need to change the associated `div.bridgelines`
 CSS class to fix it
 ([https://gitweb.torproject.org/bridgedb.git/blob/HEAD:/lib/bridgedb/templates/assets/css/custom.css#l106
 here]).

 The reason this bug is occuring is that BridgeDB used to use
 `<code>/<pre>` tags to enclose the bridge lines. Then, when we started
 giving out bridge lines which included the fingerprint, using `<code>`
 made the line wrap around, causing the fingerprints to look like they were
 on new lines by themselves. I created the `div.bridgelines` class to fix
 this, but I'm no CSS wizard.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12664#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs