[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9874 [BridgeDB]: Research/design a way to automate testing of BridgeDB's HTTPS and email distributors

#9874: Research/design a way to automate testing of BridgeDB's HTTPS and email
distributors
-------------------------+-------------------------------------------------
     Reporter:  isis     |      Owner:  isis
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:           |   Keywords:  bridgedb-unittests, automation, ci,
  BridgeDB               |  bridgedb-gsoc-application
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by trygve):

 * status:  needs_revision => needs_review


Comment:

 Thank you for feedback. I've attached a patch to fix the failing test. I'm
 new to git (used to cvs, svn and hg), so apologies if I've done this
 wrong.

 The ipv6 bridge has been changed to a vanilla ipv4 bridge. I've also added
 a new test to check for a scramblesuit bridge. Both of these surprised me
 because they had a different number of fields in each bridge line, but
 I've adjusted the tests accordingly.

 A few comments:
 * mechanize is in '.test.requirements.txt' but not 'requirements.txt'. I'm
 assuming this is intentional, but it means that the https tests fail when
 using 'requirements.txt'
 * leakspin is in '.test.requirements.txt', but its dependency 'ipaddr' is
 not
 * I had to change EMAIL_SMTP_PORT to 2525 in bridgedb.conf. This might not
 be obvious to others.
 * I had to add "127.0.0.1" to EMAIL_DOMAINS in bridgedb.conf. This might
 not be obvious to others. It may be possible to change the scripts to send
 from one of the 3 allowed domains, as the SMTP server in the test script
 should intercept these emails without forwarding on to the real domains.
 * I had to perform a few more steps to get everything to work ('leakspin
 -n 100' and 'scripts/make-ssl-cert'). This was all documented in the
 excellent README, but would it be useful to create a little script that
 sets up the test environment automatically? You've added something that
 does this for Travis CI, but I've been working from the shell, entering
 commands manually.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9874#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs