[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12859 [Stem]: Improve parsing speed with profile-directed code tuning

#12859: Improve parsing speed with profile-directed code tuning
-----------------------------+----------------------------
     Reporter:  nickm        |      Owner:  atagar
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:
    Component:  Stem         |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+----------------------------
Changes (by atagar):

 * status:  needs_review => needs_revision


Comment:

 Hi Nick, these are great! First patch in particular is fantastic (faster
 *and* drops unnecessarily convoluted code, hot!). The others however break
 the unit tests. You should be able to easily repro this with 'run_tests.py
 --unit'...

 https://stem.torproject.org/faq.html#how-do-i-run-the-tests

 I owe a couple other people code reviews but I'll go ahead and correct
 this afterward if you don't get to it before me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12859#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs