[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12684 [Firefox Patch Issues]: Make "Not Now" the default button for TorBrowser's canvas permission dialogue

#12684: Make "Not Now" the default button for TorBrowser's canvas permission
dialogue
-------------------------------------+-------------------------------------
     Reporter:  isis                 |      Owner:  isis
         Type:  defect               |     Status:  needs_review
     Priority:  critical             |  Milestone:
    Component:  Firefox Patch        |    Version:
  Issues                             |   Keywords:  tbb-usability, tbb-
   Resolution:                       |  linkability, MikePerry201408R,
Actual Points:                       |  TorBrowserTeam201408
       Points:                       |  Parent ID:
-------------------------------------+-------------------------------------

Comment (by isis):

 Replying to [comment:32 mcs]:
 > Replying to [comment:30 isis]:
 > > The only thing that I'm a tiny bit dissatisfied with is that the
 larger palette icon is a little bit pixelly.
 >
 > Is this the same image?  http://www.i2clipart.com/clipart-palette-3f87
 > There is an SVG available, which at a glance seems to scale nicely.

 Hey, thanks for finding that! It is the same image.

 I've committed the `.svg` file instead of the `.png` as a `fixup!` commit,
 and rebased my changes into my `bug12684-canvas-dialogue-order_r2`
 [https://github.com/isislovecruft/tor-browser/compare/bug12684-canvas-
 dialogue-order_r2?expand=1 branch] (or the `bug12684-canvas-dialogue-
 order_r2_squashed` [https://github.com/isislovecruft/tor-
 browser/compare/bug12684-canvas-dialogue-order_r2_squashed?expand=1
 branch] for the smooshed version).

 I rebuilt Firefox and the using the `.svg` works great (modulo whatever
 concerns about SVG being an even shittier image format than PNG). Your
 call; you've got both sets of branches now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12684#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs