Re: [tor-bugs] #8402 [Tor]: Tor should help its transport proxy use a proxy, if needed.

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#8402: Tor should help its transport proxy use a proxy, if needed.
-------------------------+-------------------------------------------------
     Reporter:  asn      |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  major    |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-bridge pt flashproxy, tbb-
Actual Points:           |  needs, tbb-helpdesk-frequent, tbb-tor-
       Points:           |  backported-3.6.1
                         |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by nickm):

 * I think we want to allow the user to specify a lot of
 ClientTransportPlugins, and have that not matter unless they actually use
 one for a bridge?  If that's so, the new behavior in get_proxy_type() and
 parse_client_transport_line() might need work.

 * I think I merged another branch to refactor
 parse_client_transport_line().  I should check whether this conflicts
 badly now.

 * The documentation in get_pt_proxy_uri() should document that it returns
 a newly allocated string or NULL.

 * Do we verify elsewhere that our Socks5 username and password don't have
 any characters that cause trouble in a URI?  Should we?  (Same question
 for HTTPSProxyAuthenticator.)

 * Do we verify elsewhere that our Socks5 username and password are either
 both set or neither set?

 * We usually prefer "unsigned int x : 1" for one-bit booleans: 1 is a less
 surprising result for true than -1 is.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8402#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs