[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10116 [Tor]: Avoid memory allocation in OOM handler

#10116: Avoid memory allocation in OOM handler
-----------------------------+-----------------------------------------
     Reporter:  nickm        |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-relay oom 026-triaged-1
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------------------

Comment (by andrea):

 Agree with Sebastian that converting to smartlist_t is the right approach.

 Begin code review:

  * db2af2abb03a82e7c71581efa04a45869feba38a: looks fine to me
  * 6969bd9a02895ae7dc80264fb59adba4a44f79a1:
    - Huh, Coccinelle looks badass.  Pattern matching on the syntax tree,
 yeah?
    - Patch looks fine to me.
  * 664b2645fbb952208a13d213bc237af868109a00: looks fine to me
  * 28641cab5282389168bed2c4e4a491daac9268f9:
    - In circuit_close_all_marked(), what updates global_circuitlist_idx on
 the circuit formerly at the tail of the list that gets swapped into the
 slot freed by SMARTLIST_DEL_CURRENT?
  * 0ba253d40cd68d8b82556c376c2adeca4ea9e2b6: looks fine to me
  * 32edeaa71056bc7a311493d568404c5ccbb8c8a3: looks fine to me

 End code review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10116#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs