[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9380 [BridgeDB]: BridgeDB should use stem for parsing descriptors according to torspec

#9380: BridgeDB should use stem for parsing descriptors according to torspec
-------------------------+-------------------------------------------------
     Reporter:  sysrqb   |      Owner:  isis
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:           |   Keywords:  stem,bridgedb-0.2.x,bridgedb-
  BridgeDB               |  parsers
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by isis):

 Replying to [comment:20 joelanders]:
 > I've got some more progress at
 https://github.com/joelanders/bridgedb/commits/fix/9380-stem_r3. Basically
 using isis's new functions from descriptors.py in Bridges.py and Main.py.
 Probably doesn't work quite right yet, and I haven't written any specs
 yet, but wanted to let someone chime in if I'm going in the wrong
 direction :)

 Thanks! Before getting into code review, I went ahead and tested your
 patches.

 I [https://travis-ci.org/isislovecruft/bridgedb/jobs/33658497 tested your
 changes] and they failed. The first reason was that #12953 was causing
 parser errors (not the fault of the parsers, it was Leekspin's fault), so
 I fixed that, [https://pypi.python.org/pypi/leekspin pushed
 Leekspin-0.2.1], and
 [https://gitweb.torproject.org/user/isis/bridgedb.git/commitdiff/41410f917297a8e667bfabf899477c300254c20f
 bumped] BridgeDB's Leekspin dependency to 0.2.1.

 Because the Leekspin version would need to be bumped for all development
 branches, I did it in the develop branch. I now have a `fix/9380-stem_r4`
 [https://gitweb.torproject.org/user/isis/bridgedb.git/shortlog/refs/heads/fix/9380-stem_r4
 branch] which is my same commits as before (in `fix/9380-stem_r3`) but
 with the Leekspin bump commit underneath them.

 Next, to test them again, I cherry-picked your commits on top. There's
 still a few issues [https://travis-
 ci.org/isislovecruft/bridgedb/builds/33660689 shown here in the CI
 results].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9380#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs