Re: [tor-bugs] #9874 [BridgeDB]: Research/design a way to automate testing of BridgeDB's HTTPS and email distributors

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#9874: Research/design a way to automate testing of BridgeDB's HTTPS and email
distributors
-------------------------+-------------------------------------------------
     Reporter:  isis     |      Owner:  isis
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:           |   Keywords:  bridgedb-unittests, automation, ci,
  BridgeDB               |  bridgedb-gsoc-application
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by isis):

 Replying to [comment:22 trygve]:
 > Added three new small patches:
 >
 > - 0001: Raise SkipTest if TESTING_BRIDGEDB environment variable not set
 in test_https.py. Also fixes bug in bridge-line parsing function which
 would fail if more than one bridge was present.

 As you've probably already noticed, BridgeDB has some logic to hand out
 different amounts of bridge lines depending on the number available (as
 you've probably noticed). It was causing some intermittent test failures
 in other later development branches, so
 [https://gitweb.torproject.org/bridgedb.git/commitdiff/9111886f2785da3995b2e1f78737326aedbcb4a7
 I went ahead and fixed it before you posted this]. :/ I'm sorry! I didn't
 realise you were already on it.

 For the `TESTING_BRIDGEDB` envvar, I'd kind of rather see this done by
 testing for a running PID,
 [https://gitweb.torproject.org/bridgedb.git/blob/refs/heads/develop:/lib/bridgedb/test/test_bridgedb.py#l83
 as how it's done here] in `lib/bridgedb/test/test_bridgedb.py`.

 > - 0002: Raise SkipTest if TESTING_BRIDGEDB environment variable not set
 in test_smtp.py

 Same as above.

 > - 0003: ipaddr was in requirements.txt but not .test.requirements.txt

 When Leekspin is installed as a dependency, it ''should'' pull in it's own
 dependencies by itself. The `.test.requirements.txt` file was meant to
 only be the ''extra'' dependencies needed to run BridgeDB's test suites,
 on top of the other ones already needed just to run BridgeDB. The `ipaddr`
 module is required to run BridgeDB.

 Did `ipaddr` somehow not get installed when you set up a BridgeDB
 instance?


 >
 > I'm sure you want to see the back of this ticket, but only that first
 one is important (I probably should have split it into two separate
 patches)

 No worries. If you want to revise this to use the PID, I'd still take !#1
 and !#2!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9874#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs