[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12948 [Tor]: TBB Linux 4.0-Alpha-1 HashedControlPassword not working

#12948: TBB Linux 4.0-Alpha-1 HashedControlPassword not working
-------------------------+-------------------------------------------------
     Reporter:  vis15    |      Owner:  isis
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor      |    Version:  Tor: unspecified
   Resolution:           |   Keywords:  TBB, Linux, HashedControlPassword,
Actual Points:           |  Alpha, regression
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by arma):

 It also occurs to me that since this case is really only for these two
 cases:
 {{{
   { "l", "Log", 1, 0},
 [...]
   { "HashedControlPassword", "__HashedControlSessionPassword", 1, 0},
 }}}
 and I don't think anybody even remembers the "-l means log" case, we might
 be better served stripping the commandline_only element of
 config_abbrev_t, and removing the command_line option to
 config_expand_abbrev(), and just adding an explicit special-case where
 this patch went, that says "if it's HashedControlPassword, then rewrite it
 to this other thing, and here's why".

 I guess there's value to having the general-case infrastructure if we
 later find a second reason to use it, but in the meantime it sure seems
 overengineered.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12948#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs