[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12029 [BridgeDB]: Redesign BridgeDB's class inheritance to make designing new distributors easier

#12029: Redesign BridgeDB's class inheritance to make designing new distributors
easier
--------------------------+-------------------------------------------
     Reporter:  isis      |      Owner:  isis
         Type:  defect    |     Status:  needs_revision
     Priority:  major     |  Milestone:
    Component:  BridgeDB  |    Version:
   Resolution:            |   Keywords:  bridgedb-dist, bridgedb-0.2.x
Actual Points:            |  Parent ID:
       Points:            |
--------------------------+-------------------------------------------

Comment (by isis):

 I separated some of the commits which were generally for refacting the
 `bridgedb.Bridges` module, which were in the `fix/12029-dist-api_r1`
 [https://gitweb.torproject.org/user/isis/bridgedb.git/shortlog/refs/heads/fix/12029
 -dist-api_r1 branch], into a new `fix/12029-refactor-Bridges`
 [https://gitweb.torproject.org/user/isis/bridgedb.git/shortlog/refs/heads/fix/12029
 -refactor-Bridges branch], because I would prefer that no one else need to
 duplicate refactoring I've already finished (as is now happening with
 joelanders in #9380).

 The commits were all chopped off the bottom of the `fix/12029-dist-api_r1`
 branch, and were these:
 {{{
 99fd8189785917dd09d9122270692a89f896b061 Fix old Tests.py;
 networkstatus.parseALine returns a string.
 5c8bf76f2379d0039637877ef9ae4bdf11a72877 Support requiring distribution of
 bridges with the "Running" flag.
 ca25134def3ac064cdd1f5d21ce583013d7318fd Rip out
 `BridgeHolder.assignmentsArePersistent()`, it's never used.
 541f927475e8574a96a03c94fc99f74b37b4d6b4 Make `isValidIP()` backwards
 compatible with deprecated `is_valid_ip()`.
 6a59652077571d700266c5ffa01ead8c55d58325 Move old b.Bridges.is_valid_ip()
 doctest to b.p.addr.isValidIP().
 20ddda862453494bfbc98c34ff70f4e00ace3bae Add note that
 bridgedb.Bridges.ID_LEN isn't used.
 fbde0bf1702347bf524452401672ac263c2ace04 Remove
 bridgedb.Bridges.HEX_DIGEST_LEN; it's completely unused.
 4d7a9f34d66d71f71c6814f219a3e3c207431d8a Deprecate
 bridgedb.Bridges.is_valid_fingerprint().
 afa33faaf90982c68e4f501c0d44646d3437eb04 Add bridgedb.interfaces module
 which simply collects all interfaces.
 d78e56e424f644da7d9f8da99ff7012b2cc922c2 Rename IBridgeRequest ?
 IRequestBridges. It's cuter.
 0ab4fbc2a531b9f7895655a18e702e3d48647f51 Add Bridges.is_valid_ip doctests
 to b.p.addr.isValidIP docstring.
 }}}

 In addition, in order to [https://travis-
 ci.org/isislovecruft/bridgedb/builds/33760790 get the tests to pass], I
 added one
 [https://gitweb.torproject.org/user/isis/bridgedb.git/commitdiff/0168a79dbbe311449cc7cba0dc859c0b3e45901d
 commit], and fixup'd
 [https://gitweb.torproject.org/user/isis/bridgedb.git/commitdiff/b4a78c72dc74158b2e2f62f8fd38915cea07add0
 another one].

 I'm merging `fix/12029-refactor-Bridges` now (for BridgeDB-0.2.4) because
 it's needed for work on other tickets.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12029#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs