[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12934 [Onionoo]: Vagrant file and the like

#12934: Vagrant file and the like
-----------------------------+--------------------------
     Reporter:  iwakeh       |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Onionoo      |    Version:
   Resolution:               |   Keywords:  vagrantfile
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by karsten):

 Replying to [ticket:12934 iwakeh]:
 > Thanks for preparing the VagrantHowto, that really helped me to get
 started quickly!

 Glad to hear!

 > I added some patches, also for the INSTALL file.
 > Could the jdk version be set to 1.7, as it is available for wheezy
 stable?

 Once 1.7 is available on the production system, yes.

 > Please review and cherry pick the changes you find appropriate.

 Committed to
 [https://gitweb.torproject.org/user/karsten/onionoo.git/shortlog/refs/heads/task-12934
 this branch] together with another commit that is supposed to be squashed
 into the first.  Does this look okay to you?  If so, I'll squash and
 commit to master.  Or feel free to squash, `git commit --amend --reset-
 author`, and `git format-patch HEAD^` to be listed as patch author.

 > Some questions:
 >  * I couldn't make sense from the `ln -s /srv/o` in vagrant/bootstrap.sh

 Indeed, that line should go away.

 >  * I couldn't find {{{deanonymind.py}}} mentioned in INSTALL. Thus, I
 didn't process geoip at all.

 The `deanonymind.py` part in the INSTALL file is outdated.  It's
 sufficient to download MaxMind's GeoIP2 database files now.  I should
 update that file.  Guess I'll do that in a more general effort to rework
 Onionoo's documentation (#13004).

 >  * For testing using vagrant the vanilla {{{server.xml}}} does not need
 to be changed. Maybe, clearly point out that the example is for people who
 want to run their own onionoo server?

 I'm not sure what you mean.  Want to provide a clarifying patch?

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12934#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs