[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #12535 [Pluggable transport]: goptlib should expose a SOCKS5 server instead of SOCKS4a.
#12535: goptlib should expose a SOCKS5 server instead of SOCKS4a.
-------------------------------------+----------------------------
Reporter: yawning | Owner: yawning
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Pluggable transport | Version:
Resolution: | Keywords: goptlib, socks
Actual Points: | Parent ID: #12130
Points: |
-------------------------------------+----------------------------
Comment (by dcf):
Replying to [comment:1 yawning]:
> This also fixes a bug inherited from the original code. If either of
the `SetDeadline` calls in `AcceptSocks` fail (unlikely), the file
descriptor will be leaked (Unless the GC will happen to take care of
closing them).
Could you fix this bug in a separate commit? (Just go ahead and commit
it.) It's important to me to keep bug fixes separate from new features.
This way the bug ends up getting recorded in the commit history too.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12535#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs