[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13339 [Tor]: Merge GSoC project - Consensus Diffs

#13339: Merge GSoC project - Consensus Diffs
-------------------------+-------------------------------------------------
     Reporter:  mvdan    |      Owner:
         Type:           |     Status:  needs_revision
  enhancement            |  Milestone:  Tor: 0.2.7.x-final
     Priority:  major    |    Version:  Tor: 0.2.7
    Component:  Tor      |   Keywords:  gsoc, merge, tor-client, prop140,
   Resolution:           |  027-triaged-1-in,TorCoreTeam201508
Actual Points:           |  Parent ID:
       Points:  medium   |
-------------------------+-------------------------------------------------

Comment (by nickm):

 Replying to [comment:25 mvdan]:
 > I've addressed most of the comments:
 https://github.com/mvdan/tor/commits/consdiff
 >
 > The last commit adds four TODOs, which I think are the only things left
 to deal with.
 >
 > > // TODO: change bool with max size to take up in disk
 >
 > I'll do this one.

 Great.

 > > // TODO: check that the stored consensus is intact
 >
 > Not sure how to do this one yet.

 Hm.  Maybe we should store it along with a digest, or try to parse it
 before we compute the diff?

 > > // TODO: duplicate code from add_networkstatus_bytes_to_outbuf, works
 but is
 > > // probably buggy.
 >
 > All of this code is confusing to me, so help from someone who initially
 wrote it would be great.
 >
 > > // TODO: might want to do this in the background and have a lock to
 not
 > > // serve consensus diffs until they are updated
 >
 > What do we want to do about this one after all?

 I can do these last two.

 The final one will depend on the runtime of the code.  How long does it
 take to recompute all the diffs?  If it's a few milliseconds, that's fine.
 If it's a few '''hundred''' milliseconds or worse, we probably need to
 stick it in another thread.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13339#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs