[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16695 [Tor]: Decouple generating controller events from sending them to controllers

#16695: Decouple generating controller events  from sending them to controllers
------------------------+---------------------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  needs_revision
     Priority:  normal  |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  SponsorS TorCoreTeam201508 blob
Actual Points:          |  Parent ID:  #16764
       Points:          |
------------------------+---------------------------------------------

Comment (by nickm):

 Re multithreading:

 I'm pretty sure this stuff isn't reachable from other threads, but it
 would be nice to clean it up anyway in case I'm wrong.

 Re error handling:

 It can't hurt to assert that the return value is non-null, though we could
 never reach that point in the Tor code if the base were absent.

 We should check the return value of tor_event_new, but event_active()
 shouldn't be able to fail.

 I like the assertion idea too.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16695#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs