[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #16767 [metrics-lib]: Javadoc doesn't include any of the documentation.
#16767: Javadoc doesn't include any of the documentation.
-----------------------------+----------------------------
Reporter: leeroy | Owner: karsten
Type: enhancement | Status: needs_revision
Priority: minor | Milestone:
Component: metrics-lib | Version:
Resolution: | Keywords:
Actual Points: | Parent ID:
Points: |
-----------------------------+----------------------------
Comment (by leeroy):
Replying to [comment:13 nickm]:
> We take patches; but they have to be good clean ones. We offer advice
in helping people make their patches good and clean; but we have no power
to compel people to listen.
>
> Ultimately, I am sorry that you didn't find our community to meet the
ideals of open-source software development. I sincerely wish you the best
of fortune finding another community that suits your needs, your desires,
and your preferred interaction style.
>
> (Leaving as needs_revision since the appearance to me is that there
could conceivably be an issue here in need of a clean fix.)
I think you misunderstand Nick. If the fix looks ugly, it's because of how
it was originally implemented. The fix is clean. Much better. I don't like
to quote percentages. Karsten didn't even review the fix. If they had they
would have seen it's vastly better.
I even went to the effort of creating a gitweb and repo. Just to make it
easy.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16767#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs